Ungroup Item in general page #3406

onesounds · 2025-03-31T11:31:20Z

What's the PR

coderabbitai · 2025-03-31T11:34:09Z

📝 Walkthrough

Walkthrough

The changes update the settings user interface in the Flow.Launcher settings page. A grouped card section combining "startFlowLauncherOnSystemStartup" and "hideOnStartup" has been split: the former is now a cc:ExCard featuring a SideContent toggle switch, while the latter becomes a standalone cc:Card with updated icon and subtext properties. Additionally, a separate card group containing "searchDelay" and "searchDelayTime" has been removed from the UI layout.

Changes

File(s)	Change Summary
Flow.Launcher/SettingPages/.../SettingsPaneGeneral.xaml	Replaced `cc:CardGroup` with a `cc:ExCard` (with a `SideContent` toggle switch) for "startFlowLauncherOnSystemStartup" and a standalone `cc:Card` for "hideOnStartup"; removed the `cc:CardGroup` for "searchDelay" and "searchDelayTime".

Suggested labels

enhancement, kind/ui, 5 min review

Suggested reviewers

Jack251970

Poem

I'm a bunny hopping through lines of code,
Transforming cards on a joyful road.
ExCard shines with a toggle so neat,
Standalone settings now skipping a beat.
With a hop and a wink, I cheer these changes complete! 🐰

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0e4e95a and ce93e24.

📒 Files selected for processing (1)

Flow.Launcher/SettingPages/Views/SettingsPaneGeneral.xaml (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: gitStream.cm

🔇 Additional comments (3)

Flow.Launcher/SettingPages/Views/SettingsPaneGeneral.xaml (3)

31-50: Clean UI improvement using ExCard with SideContent

The transformation from a CardGroup to an ExCard with SideContent for the "startFlowLauncherOnSystemStartup" setting improves the UI by creating a cleaner visual hierarchy. The toggle switch is now appropriately placed in a dedicated SideContent section while maintaining the nested card for "useLogonTaskForStartup".

This change aligns with modern UI design patterns by providing a clear parent-child relationship between related settings.

51-59: Good standalone presentation with enhanced visual elements

Converting "hideOnStartup" to a standalone card with proper icon () and subtext improves its visual presentation and information clarity. This change creates a better separation of concerns between startup behavior settings that were previously grouped together.

31-59:
❓ Verification inconclusive

Verify that removed searchDelay settings were intentional

The PR has completely removed the CardGroup containing "searchDelay" and "searchDelayTime" settings. While the UI looks cleaner, ensure this removal was intentional and that these settings are either no longer needed or are accessible elsewhere.

🏁 Script executed:
#!/bin/bash
# Check if searchDelay settings were moved elsewhere or if they're referenced in code
rg -A 1 -B 1 "searchDelay|searchDelayTime" --type cs --type xaml
Length of output: 95

Action Required: Confirm Removal of "searchDelay" Settings

The initial verification encountered an error due to file type recognition (i.e. using --type xaml), so please run the above updated command. Verify that there are no remaining references to “searchDelay” or “searchDelayTime” in both XAML and C# files. If no such references exist, confirm that the removal was intentional and that these settings are redundant or have been relocated elsewhere in the codebase.

🏁 Script executed:
#!/bin/bash
# Re-run the search for 'searchDelay' and 'searchDelayTime' settings in .xaml and .cs files using glob patterns
rg -A 1 -B 1 "searchDelay|searchDelayTime" -g "*.xaml" -g "*.cs"
Length of output: 5645
Verify Search Delay Settings Removal Intent

The CardGroup for search delay settings ("searchDelay" and "searchDelayTime") has been removed from the SettingsPaneGeneral.xaml UI. However, our inspection shows that these settings are still referenced in the code—specifically in PluginViewModel.cs, MainViewModel.cs, the SearchDelayTimeWindow (both its XAML and code-behind), and relevant translation keys in Languages/en.xaml. Please confirm that:

The removal of these settings from the main settings pane was intentional.

The search delay functionality is now exclusively managed via the SearchDelayTimeWindow or an alternative mechanism.

Any necessary updates (e.g., documentation or cleanup of now-redundant code) have been considered.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai plan to trigger planning for file edits and PR creation.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-04-01T07:21:59Z

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors	Count
❌ forbidden-pattern	22
⚠️ non-alpha-in-dictionary	19

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

binary file (or some other file you wouldn't want to check at all).

Please add a file path to the excludes.txt file matching the containing file.

File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).
well-formed pattern.

If you can write a pattern that would match it,
try adding it to the patterns.txt file.

Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

Note that patterns can't match multiline strings.

Ungroup Item in general page

ce93e24

github-actions bot assigned onesounds Mar 31, 2025

This comment has been minimized.

Sign in to view

Jack251970 self-requested a review April 1, 2025 07:19

Jack251970 approved these changes Apr 1, 2025

View reviewed changes

Merge branch 'dev' into 250331-UngroupItem

47b6580

onesounds enabled auto-merge April 1, 2025 07:20

gitstream-cm bot added the 1 min review label Apr 1, 2025

onesounds merged commit a3c18a6 into Flow-Launcher:dev Apr 1, 2025
6 checks passed

Jack251970 added enhancement New feature or request kind/ui related to UI, icons, themes, etc and removed 1 min review labels Apr 4, 2025

jjw24 added this to the 1.20.0 milestone Apr 9, 2025

coderabbitai bot mentioned this pull request May 23, 2025

Support Always Run As Administrator #3573

Open

jjw24 mentioned this pull request May 27, 2025

Release 1.20.0 | Plugin 4.5.0 #3269

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Ungroup Item in general page #3406

Ungroup Item in general page #3406

onesounds commented Mar 31, 2025

Uh oh!

This comment has been minimized.

coderabbitai bot commented Mar 31, 2025

Walkthrough

Changes

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

github-actions bot commented Apr 1, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Ungroup Item in general page #3406

Ungroup Item in general page #3406

Conversation

onesounds commented Mar 31, 2025

What's the PR

Uh oh!

This comment has been minimized.

coderabbitai bot commented Mar 31, 2025

Walkthrough

Changes

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions bot commented Apr 1, 2025

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

CodeRabbit Configuration File (`.coderabbit.yaml`)